feat(oauth): remove code according to user prompts #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-fullstack into fix/remove-oauth-code Conflicts: app/templates/server/config/_local.env.js
| @@ -166,6 +166,7 @@ var AngularFullstackGenerator = yeoman.generators.Base.extend({ | |||
| if(answers.mongoose) this.filters.mongoose = true; | |||
| if(answers.auth) this.filters.auth = true; | |||
| if(answers.oauth) { | |||
| if(answers.oauth.length) this.filters['oauth'] = true; | |||
There was a problem hiding this comment.
Why not this.filters.oauth = true?
There was a problem hiding this comment.
I was using an other name before with a -, so the array markup was needed, not anymore now so if you really prefer the dot notation I could switch
There was a problem hiding this comment.
Hum oh and the global syntax of the index.js was this way before but seems to have changed now
|
Since it's relevant for #359, can we have this merged? |
|
Don't really know if I have to squash the merge commit with this one, let me now :) |
DaftMonk
added a commit
that referenced
this pull request
Jul 22, 2014
feat(oauth): remove code according to user prompts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add one global oauth filter that is set to true when we have at lease one oAuth strategy to simplify some conditions.
Remove all code that is not necessary depending on what is taken at the initialization.
Applied in style files, login and signup controllers / views, user model and env config file.